Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reader: fix jgf properties #1149

Merged

Commits on Mar 14, 2024

  1. reader: check type of properties in jgf

    Problem: the JGF reader requires each vertex's 'properties' field
    to be either null or a JSON object, but doesn't ever check the type.
    This leads to silent failures when the type read in is wrong.
    
    Add a check for the type of the properties field if it is not null.
    jameshcorbett committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    6def797 View commit details
    Browse the repository at this point in the history
  2. python: fix JGF writer properties

    Problem: the Python JGF writer outputs properties as a list by
    default, but the reader expects a mapping.
    
    Change the default to a dictionary.
    jameshcorbett committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    8c13ac6 View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2024

  1. test: add jgf writer property tests

    Problem: there are no tests that the JGF writer handles
    properties correctly.
    
    Add them.
    jameshcorbett committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    1d08ea4 View commit details
    Browse the repository at this point in the history
  2. test: fix ion-R expected property format

    Problem: t/t8001-util-ion-R.t expects JGF properties to be formatted
    as a JSON array, but they are actually given by a mapping.
    
    Fix the expected type.
    jameshcorbett committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    f2f2899 View commit details
    Browse the repository at this point in the history