autoconf removal #1196
autoconf removal #1196
Conversation
|
The extra commit is here because this is where the problem surfaced. I'm not sure why it surfaced here, but the cgo build for the go test was looking for libczmq, which is apparently no longer found in the focal image for some reason. |
|
flux-core dropped the czmq dependency awhile ago. |
|
I saw that, it's extremely odd to me that this just happened now... Maybe it's just when the containers got poked? Not sure. |
There was a problem hiding this comment.
a little late to the party here, a few things
- remove autogen.sh
- remove INSTALL, since that's the GNU autoconf boilerplate one
- update README.md with new build instructions (it still mentions autogen.sh, ./configure)
- Update: remove configure? rename configure-cmake to configure?
hopefully not something else I'm forgetting
|
Ok, I wasn't planning to rework docker-run-checks.sh for this, so I'll do whatever of that I can without breaking it, or only small tweaks. The |
problem: The cmake toolchain has been the main way to build and use flux-sched for a while now, it's substantially faster and substantially less broken. The autotools build system still exists, but is going to become even more broken over time. solution: Remove the autotools build system
problem: the go-bindings test was failing for lack of a libczmq library, which seems to no longer be installed or needed for flux core. solution: remove the flag, the tests pass without it 🤷🏼♂️
problem: now that we're a primarily cmake-based build, the autotools-style build instructions no longer make sense. solution: make cmake the main thing we recommend while explaining the alternative.
|
Turns out autogen being missing just pops a warning in |
|
Anyone willing to sign off here? |
trws
added
the
merge-when-passing
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1196 +/- ##
======================================
Coverage 73.9% 73.9%
======================================
Files 102 102
Lines 14595 14595
======================================
Hits 10790 10790
Misses 3805 3805 |
As suggested by @garlick over in #1195, splitting out the autotools removal since that's a much easier unit if it doesn't have all the file moves mixed in.