docker-run-checks: ensure we match user's home #1197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
problem: docker-run-checks.sh currently assumes that mounting $HOME to /home/$USER will match the outer system. Sometimes that is not the case. Example, my lima-managed vm uses /home/$USER.linux as the home directory for the vm user, which causes strange errors because of the mismatch. solution: map $HOME to $HOME
|
Assuming everything passes here, would be nice to get this one matching flux-core. |
trws
added
the
merge-when-passing
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1197 +/- ##
======================================
Coverage 73.9% 73.9%
======================================
Files 102 102
Lines 14595 14595
======================================
Hits 10790 10790
Misses 3805 3805 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
problem: docker-run-checks.sh currently assumes that mounting $HOME to /home/$USER will match the outer system. Sometimes that is not the case. Example, my lima-managed vm uses /home/$USER.linux as the home directory for the vm user, which causes strange errors because of the mismatch.
solution: map $HOME to $HOME