Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reformat #1218

Merged
merged 3 commits into from
Jul 11, 2024
Merged

Reformat #1218

merged 3 commits into from
Jul 11, 2024

Commits on Jul 11, 2024

  1. format: treat pack/unpack functions as normal 

    problem: we were special-casing pack and unpack functions to prevent
them from being formatted

solution: stop special-casing them
    @trws
    trws committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    0cd2ff8 View commit details
    Browse the repository at this point in the history

  2. scripts/format: add a command to apply clang-format 

    problem: we don't automatically check c/c++ formatting on push

solution: add clang-format to the check-format script

I also renamed "python formatting" to "code formatting" here so that
would stay accurate
    @trws
    trws committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    b4c5996 View commit details
    Browse the repository at this point in the history

  3. format: apply clang-format to all our code 

    problem: we spend a lot of time on code formatting, and have a somewhat
inconsistent style

solution: automate it with clang-format
    @trws
    trws committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    806f8fc View commit details
    Browse the repository at this point in the history