Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solve portability issues for Ubuntu 16.04.4 LTS #298

Merged
merged 7 commits into from Mar 30, 2018

Commits on Mar 30, 2018

  1. build: use AX_BOOST_GRAPH macro

    Problem: --with-boost=path has no effect on the search
    location for libboost_graph.so.
    
    boost_graph is found with AC_CHECK_LIB, while the rest of boost
    is found with purpose-build autoconf macros.  The macro for
    boost_graph is included but not used.
    
    Call AX_BOOST_GRAPH and adjust Makefiles accordingly.
    garlick committed Mar 30, 2018
    Copy the full SHA
    b9f16e9 View commit details
    Browse the repository at this point in the history
  2. build: fix bug in AX_BOOST_GRAPH macro

    Problem: AX_BOOST_GRAPH, in its search for the
    graph library, matches libboost_graph_parallel.so
    over libboost_graph.so, but graph_parallel is not
    a replacement for graph.
    
    Alter the glob used so that it doesn't match
    graph_parallel.
    garlick committed Mar 30, 2018
    Copy the full SHA
    d8f3f2d View commit details
    Browse the repository at this point in the history
  3. build: [g++-5.4.0] suppress boost warnings

    Problem: sched fails to compile with gcc-5.4.0
    and boost-1.53 due to excessive compiler warnings
    that are treated as errors.
    
    Suppress the following warnings completely:
      unused-local-typedefs
      deprecated-declarations
      unused-variable
      maybe-uninitialized
    garlick committed Mar 30, 2018
    Copy the full SHA
    8a4b016 View commit details
    Browse the repository at this point in the history
  4. build: add AX_BOOST_REGEX

    Problem: boost_regex library, apparently a dependency of
    boost_graph, cannot be found during linkage.
    
    Add AX_BOOST_REGEX macro and adjust Makefile.am accordingly.
    garlick committed Mar 30, 2018
    Copy the full SHA
    cb1d0f9 View commit details
    Browse the repository at this point in the history
  5. build: add BOOST_LDFLAGS

    Problem: cannot find boost libraries when building test
    executables.
    
    When linking against a side installed boost, $(BOOST_LDFLAGS)
    is required.  Add it.
    garlick committed Mar 30, 2018
    Copy the full SHA
    db52816 View commit details
    Browse the repository at this point in the history
  6. resource: [cleanup] avoid 'using namespace boost'

    Problem: with g++ 5.4.0, the integer types in stdint.h
    (or cstdint) have the same names as types defined within
    boost, resulting in "ambiguous type" errors.
    
    Avoid 'using namespace boost' in Flux code.  Instead,
    prefix all boost symbols with boost::
    garlick committed Mar 30, 2018
    Copy the full SHA
    61e9b8e View commit details
    Browse the repository at this point in the history
  7. build: add -Wno-error to resource build

    Problem: clang-3.8 doesn't grok -Wno-maybe-uninitialized,
    and gcc-5.4.0 doesn't grok -Wno-error=unknown-warning-option.
    
    For now, add -Wno-error in the resource directory
    and drop -Wno-maybe-uninitialized so we can get this built
    on travis.
    garlick committed Mar 30, 2018
    Copy the full SHA
    6856990 View commit details
    Browse the repository at this point in the history