Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

travis: change email notifications to go to the flux-sched-dev listserv #353

Merged
merged 1 commit into from
Jul 16, 2018

Conversation

SteVwonder
Copy link
Member

This should make the cron failure notifications more visible to the flux-sched devs (and generally anyone interested in being notified of flux-sched build changes).

Does anyone know who the owner of flux-sched-dev is? I went to make my own list and noticed this one already existed. I requested to subscribe. Maybe @garlick or @grondo is the owner?

I marked it as "in progress" until we know at least 1 person has successfully subscribed to the list.

@dongahn
Copy link
Member

dongahn commented Jul 3, 2018

Does anyone know who the owner of flux-sched-dev is?
Somehow I was an owner and I clicked the link embedded in the email. Did you get an email back about being included in the list?

@dongahn
Copy link
Member

dongahn commented Jul 3, 2018

What does

on_success: change

do?

@SteVwonder
Copy link
Member Author

Did you get an email back about being included in the list?

Not yet. I'll keep an eye out and update here if I do.

What does on_success: change do?

on_success: change is actually the default setting. I just put it in there to be explicit. It only sends an email when the build status changes to successful from a failed state. I figured this would preferable to always which would result in an email everyday when the cron job runs. on_failure: always (also a default) makes sure we always get alerted to failures. relevant documentation: https://docs.travis-ci.com/user/notifications/#Changing-notification-frequency

@SteVwonder
Copy link
Member Author

Oh, and PR builds don't trigger email notifications. So (hopefully) we only receive emails from Travis when the cron job fails and then 1 success email immediately after we fix the problem.

@dongahn
Copy link
Member

dongahn commented Jul 3, 2018

Let me just see LISTSERV to see if you have been added to the list.

@dongahn
Copy link
Member

dongahn commented Jul 3, 2018

You had not been added. I manually added you so you should get an notification soon.
screen shot 2018-07-02 at 5 16 23 pm

@SteVwonder
Copy link
Member Author

I got the notification. Thanks!

@codecov-io
Copy link

codecov-io commented Jul 3, 2018

Codecov Report

Merging #353 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #353   +/-   ##
=======================================
  Coverage   73.96%   73.96%           
=======================================
  Files          61       61           
  Lines       10211    10211           
=======================================
  Hits         7553     7553           
  Misses       2658     2658

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95862f6...f43260d. Read the comment docs.

@coveralls
Copy link

coveralls commented Jul 3, 2018

Coverage Status

Coverage remained the same at 75.421% when pulling f43260d on SteVwonder:email-notification into 95862f6 on flux-framework:master.

@dongahn
Copy link
Member

dongahn commented Jul 14, 2018

@SteVwonder: Is this ready? Please rebase though.

@SteVwonder
Copy link
Member Author

Yeah, this should be ready to go. Once #349 is merged, I will rebase and this can be merged.

@SteVwonder
Copy link
Member Author

@dongahn: I just rebased on top of your planner PR. Once Travis goes green, this should be good to merge at your leisure. Thanks!

@dongahn
Copy link
Member

dongahn commented Jul 16, 2018

LGTM.

@dongahn dongahn merged commit 371ae9d into flux-framework:master Jul 16, 2018
@SteVwonder SteVwonder deleted the email-notification branch February 16, 2019 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants