Default policy changes #843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an one-line default match policy change in the fluxion module code. Adjust those test cases that use sched-fluxion-resource without an explict match policy set. The baseline testing results were established with policy=high so we add that policy explicitly.
Change the default policy for resource-query to be "first match". Adjust the test cases.
Set the default queue-depth to be 32 (from 8K), given that many of the current users require high throughput scheduling and the new default can significantly improve the scheduler performance.
Problem: the valgrind test runs longer on focal with the first match policy default. Increase the timeout value by 100 more seconds.
Codecov Report
@@ Coverage Diff @@
## master #843 +/- ##
========================================
- Coverage 73.7% 73.7% -0.1%
========================================
Files 82 82
Lines 9332 9332
========================================
- Hits 6879 6878 -1
- Misses 2453 2454 +1
|
|
This should be ready for a review. |
SteVwonder
approved these changes
May 20, 2021
SteVwonder
added
the
merge-when-passing
|
Thanks @SteVwonder.
Probably this can be attributed to more extensive use of C++ containers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the default match policy to "first match" and the default queue-depth to 32. Given that many of the current users require high throughput scheduling and it would make sense the default values are tuned for them. For system-instance, the policies will be configured and set differently through configuration and rc files.
Fixes #827, #830.