rfc24: Add redirect event #206
Conversation
| (string) The stream name (e.g. `stdout`, `stderr`). All valid stream | ||
| names MUST appear as keys in the header `encoding` object. | ||
|
|
||
| The following keys are OPTIONAL in the event context object: |
There was a problem hiding this comment.
Just a thought, we may want to add an optional rank key to indicate the tasks to which the redirect applies. This would allow some tasks to be redirected and not others in the future. (e.g. redirect all tasks except rank 0 to /dev/null)
There was a problem hiding this comment.
yeah, I went back and forth on that. Now that I think about it, I suppose if the redirect applies to all ranks, the rank be == all? So we should make the rank a requirement.
There was a problem hiding this comment.
oh wait, ranks are idset strings. Hmmm. Should we allow idset string or "all"? Just trying to think of how shell & job-attach handle this. one line per task is cumbersome for the "all" case.
There was a problem hiding this comment.
Would it be too difficult to generate the correct idset in the shell output plugin?
There was a problem hiding this comment.
Nah, that shouldn't be too hard.
I was mostly thinking about how to recognize that all tasks have been redirected, but we can can count idsets just like EOFs and we'd be fine.
I was also hoping to output a single message if both stdout/stderr were redirected to the same file, but I suppose that can be two messages.
There was a problem hiding this comment.
I was also hoping to output a single message if both stdout/stderr were redirected to the same file, but I suppose that can be two messages.
Ah, that is a good point. Maybe stream could be a list? Eh, maybe two events is ok like you say.
|
re-pushed adding ranks |
|
re-pushed with different filename in example, to pass spellcheck |
|
Ok, merging. |
Per discussion in flux-framework/flux-core#2395 and flux-framework/flux-core#2399