This repository has been archived by the owner on Feb 25, 2024. It is now read-only.
Uncommented method to possibly fix a bug with number range inputs #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request!! I just fixed the bug with Version 4.3.3 of LiveVoting. Thx again! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you create a "Range Input"-Question, there is a clear button on the GUI which is activated after the user gave his first answer. If the user clicks on this button, he gets an error and will be redirected to the error page.
The error mesage was:
Call to undefined method xlvoNumberRangeGUI::clear()As I found in the class xlvoNumberRangeGUI, around line 53, the function
clear()is commented out. If I uncomment this method, it seems to work.I don't know LiveVoting well enough to know if this really is a bugfix. Just wanted to let you know about it with this PR.