Skip to content
This repository has been archived by the owner on Feb 25, 2024. It is now read-only.

Unbreak delete-an-option #21

Closed
wants to merge 1 commit into from
Closed

Unbreak delete-an-option #21

wants to merge 1 commit into from

Conversation

Rillke
Copy link

@Rillke Rillke commented May 23, 2019

Update options prior to storing them: Currently, it is not possible to delete an option in a SC/MC question through GUI because it is first deleted but later restored in renegerateOptionSorting().

Update options prior to storing them: Currently, it is not possible to delete an option in a SC/MC question through GUI because it is first deleted but later restored in renegerateOptionSorting().
@Rillke
Copy link
Author

Rillke commented May 23, 2019

@mstuder Would you mind reviewing this pull request?

Reproducing the issue:

  • Create a LiveVoting Ojbect
  • In Content, click Manage
  • Click "Add Question"
  • Select Single/MC and confirm
  • Add a title, a Question text and at least 2 options
  • Click "Create"
  • Try to delete one option after the question was saved by clicking (-) next to the option and confirm with "update"

Result:
Option not deleted.

Expected: Option deleted.

@mstuder
Copy link
Member

mstuder commented Oct 4, 2019

@Rillke, thank you for your pull request-s(!) and your work for live voting! I just fixed the bug with Version 4.3.3 of LiveVoting.

Martin

@mstuder mstuder closed this Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants