Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(0.24.1) added generator and bumped 0.24.0 to 0.24.1 #45

Merged
merged 1 commit into from Dec 12, 2021

Conversation

haarchri
Copy link
Collaborator

@haarchri haarchri commented Dec 12, 2021

Signed-off-by: haarchri chhaar30@googlemail.com

What this PR does / why we need it:

  • bump upstream flux 0.24.0 to 0.24.1
  • added generator to get all crds, add our lables, add if block
  • added make generate
  • added make helmdocs
  • added make check-diff

Special notes for your reviewer:

  • as followup we should add in ci generate,helmdocs,check-diff then we can check that all needed steps are executed in the commit
  • as followup we should generate version in Chart.yaml
  • as followup we should generate imagetags from upstream
  • as followup we should generate version, chartVersion, imagetag in all testfiles
  • generator.sh uses FLUX2_VERSION out of Makefile
make generate
09:06:34 [ .. ] Fetch Flux2 GitRepo
HEAD ist jetzt bei ff7df54 Merge pull request #2178 from fluxcd/update-components
09:06:35 [ OK ] Fetch Flux2 GitRepo
09:06:35 [ .. ] Generating CRDs
09:06:45 [ OK ] Generating CRDs
make helmdocs
helm-docs
INFO[2021-12-12T09:10:14+01:00] Found Chart directories [charts/flux2, charts/flux2-sync] 
INFO[2021-12-12T09:10:14+01:00] Generating README Documentation for chart /Users/haarchri/Documents/fluxcd-community/helm-charts/charts/flux2-sync 
INFO[2021-12-12T09:10:14+01:00] Generating README Documentation for chart /Users/haarchri/Documents/fluxcd-community/helm-charts/charts/flux2 
make check-diff
09:06:50 [ .. ] checking that branch is clean
09:06:50 [ OK ] branch is clean

Checklist

  • DCO signed
  • Chart Version bumped
  • helm-docs are updated
  • Helm chart is tested

Signed-off-by: haarchri <chhaar30@googlemail.com>
@haarchri haarchri reopened this Dec 12, 2021
Copy link
Collaborator

@dwerder dwerder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dwerder dwerder merged commit 567a4ab into fluxcd-community:main Dec 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants