reimplement list of kustomizations to avoid conflicts ... #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwerder
force-pushed
the
bugfix/kusomizationlist
branch
from
6e63471
to
d59d3bd
Compare
|
FYI: @bvoq |
dwerder
force-pushed
the
bugfix/kusomizationlist
branch
from
d59d3bd
to
4a8bd65
Compare
…s to do it Signed-off-by: Daniel Werdermann <daniel.werdermann@gmail.com>
dwerder
force-pushed
the
bugfix/kusomizationlist
branch
from
4a8bd65
to
16892e2
Compare
|
So this will really mess up the setup of people already using this chart, I think it will be better to convert this to a new chart and mark the existing one as deprecated. |
|
We found a simpler solution. See #60 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... between two ways
Signed-off-by: Daniel Werdermann daniel.werdermann@gmail.com
What this PR does / why we need it:
This is a BREAKING CHANGE in the flux-sync chart. Before that PR there were 2 ways to generate a kustamization, which can result in conflicts. The new way is more generic and straight forward.
I removed the values for
kustomizationandkustomizationlistand replaced it withkustomizations.Which issue this PR fixes
Special notes for your reviewer:
Checklist
make reviewable