Merge pull request #190 from olga-mir/fix-promotion-usecase

Fix promoting canary when max weight is not a multiple of step
fluxcd · May 23, 2019 · beed636 · beed636
2 parents 94e5bfc + 9618d2e
commit beed636
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/pkg/controller/scheduler.go b/pkg/controller/scheduler.go
@@ -360,7 +360,7 @@ func (c *Controller) advanceCanary(name string, namespace string, skipLivenessCh
 		c.recordEventInfof(cd, "Advance %s.%s canary weight %v", cd.Name, cd.Namespace, canaryWeight)
 
 		// promote canary
-		if canaryWeight == maxWeight {
+		if canaryWeight >= maxWeight {
 			c.recordEventInfof(cd, "Copying %s.%s template spec to %s.%s",
 				cd.Spec.TargetRef.Name, cd.Namespace, primaryName, cd.Namespace)
 			if err := c.deployer.Promote(cd); err != nil {