Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple trigger of rollback via status phase #1467

Open
fblgit opened this issue Jul 25, 2023 · 2 comments
Open

Simple trigger of rollback via status phase #1467

fblgit opened this issue Jul 25, 2023 · 2 comments

Comments

@fblgit
Copy link

fblgit commented Jul 25, 2023

Describe the feature

A simple mechanism to trigger a rollback on a canary by merely patching status phase

Proposed solution

Similarly to #1252

  • Introduce CanaryPhase pkg/apis/flagger/v1beta1/status.go and pkg/canary/status.go
  • Update artifacts/flagger/crd.yaml kustomize/base/flagger/crd.yaml and charts/flagger/crds/crd.yaml
  • Add a new condition to trigger runRollbackHooks or rollback across pkg/controller/scheduler.go
  • Add a test case on pkg/controller/webhook_test.go to validate the rollback

Any alternatives you've considered?

There may be other ways to implement it, open to suggestions and i'll be happy to push a PR for it.

@fblgit
Copy link
Author

fblgit commented Jul 27, 2023

@stefanprodan will a PR like this be merged ? Or you have any other implementation idea that u'd like me to take a look?

@aryan9600
Copy link
Member

this should be possible to achieve by patching .status.failedChecks to be >= .spec.threshold.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants