We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A simple mechanism to trigger a rollback on a canary by merely patching status phase
Similarly to #1252
pkg/apis/flagger/v1beta1/status.go
pkg/canary/status.go
artifacts/flagger/crd.yaml
kustomize/base/flagger/crd.yaml
charts/flagger/crds/crd.yaml
runRollbackHooks
rollback
pkg/controller/scheduler.go
pkg/controller/webhook_test.go
There may be other ways to implement it, open to suggestions and i'll be happy to push a PR for it.
The text was updated successfully, but these errors were encountered:
@stefanprodan will a PR like this be merged ? Or you have any other implementation idea that u'd like me to take a look?
Sorry, something went wrong.
this should be possible to achieve by patching .status.failedChecks to be >= .spec.threshold.
.status.failedChecks
.spec.threshold
No branches or pull requests
Describe the feature
A simple mechanism to trigger a rollback on a canary by merely patching status phase
Proposed solution
Similarly to #1252
pkg/apis/flagger/v1beta1/status.go
andpkg/canary/status.go
artifacts/flagger/crd.yaml
kustomize/base/flagger/crd.yaml
andcharts/flagger/crds/crd.yaml
runRollbackHooks
orrollback
acrosspkg/controller/scheduler.go
pkg/controller/webhook_test.go
to validate the rollbackAny alternatives you've considered?
There may be other ways to implement it, open to suggestions and i'll be happy to push a PR for it.
The text was updated successfully, but these errors were encountered: