feat: analytics webhook retries #1520
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kwasniewski
force-pushed
the
rollout_webhook_retry_fixed
branch
from
3d8dd05
to
de5cd1e
Compare
Signed-off-by: Joseph Kwasniewski <kwasniewski@gmail.com>
Signed-off-by: Joseph Kwasniewski <kwasniewski@gmail.com>
Signed-off-by: Joseph Kwasniewski <kwasniewski@gmail.com>
Kwasniewski
force-pushed
the
rollout_webhook_retry_fixed
branch
from
ce228dc
to
a5460ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current situation
When we have an analytics webhook that failures we instantly increase the overall canary failure count.
Proposal
This PR adds in pre-webhook configuration for retries before increasing the failure count for the canary deployment.
If this option is not set, it will continue the current behavior of increasing the failure count.
This is trying to address issue #1501 and a slight more robust version of PR #1508