Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check prometheus is online with simple query #557

Merged
merged 1 commit into from Apr 15, 2020
Merged

Conversation

n0rad
Copy link
Contributor

@n0rad n0rad commented Apr 15, 2020

This fix #553 by replacing online check on status/flag with a simple query

@codecov-io
Copy link

codecov-io commented Apr 15, 2020

Codecov Report

Merging #557 into master will increase coverage by 0.06%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #557      +/-   ##
==========================================
+ Coverage   52.65%   52.72%   +0.06%     
==========================================
  Files          63       63              
  Lines        4938     4922      -16     
==========================================
- Hits         2600     2595       -5     
+ Misses       1930     1924       -6     
+ Partials      408      403       -5     
Impacted Files Coverage Δ
pkg/metrics/providers/prometheus.go 67.64% <50.00%> (+6.93%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4890a71...4a4f855. Read the comment docs.

Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @n0rad

Copy link
Collaborator

@mathetake mathetake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @n0rad 🎉

@mathetake mathetake merged commit 0d1e415 into fluxcd:master Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support compatible prometheus service
4 participants