Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update README: custom metric instead of custom promql #596

Merged
merged 1 commit into from
May 27, 2020

Conversation

mathetake
Copy link
Collaborator

now custom metrics/templates are not restricted to prometheus

Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

good catch 👍

@codecov-commenter
Copy link

codecov-commenter commented May 27, 2020

Codecov Report

Merging #596 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #596   +/-   ##
=======================================
  Coverage   55.00%   55.00%           
=======================================
  Files          62       62           
  Lines        5303     5303           
=======================================
  Hits         2917     2917           
  Misses       1959     1959           
  Partials      427      427           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5a3b9d...893a532. Read the comment docs.

@mathetake mathetake merged commit 44cee42 into master May 27, 2020
@mathetake mathetake deleted the fix/doc-promql branch May 27, 2020 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants