Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support AWS App Mesh backends ARN #729

Merged
merged 6 commits into from
Nov 23, 2020
Merged

Support AWS App Mesh backends ARN #729

merged 6 commits into from
Nov 23, 2020

Conversation

jddcarreira
Copy link
Contributor

This is a fix for #728 .

This PR performs the following changes:

  • Updates the AWS App Mesh types
  • Adds the support for the AWS App Mesh backend list to be used the ARN's of a virtual service
  • Updated the App Mesh guide with backend example using ARN

stefanprodan
stefanprodan approved these changes Nov 20, 2020
View reviewed changes
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @jddcarreira 🥇

@stefanprodan stefanprodan merged commit bc51509 into fluxcd:master Nov 23, 2020
@jddcarreira jddcarreira deleted the supportAppMeshBackendARN branch November 23, 2020 09:16
@stefanprodan stefanprodan mentioned this pull request Dec 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanprodan stefanprodan stefanprodan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jddcarreira @stefanprodan