Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

add "skipDepUpdate" config parameter to HelmRelease #1712

Merged
merged 1 commit into from
Feb 8, 2019
Merged

add "skipDepUpdate" config parameter to HelmRelease #1712

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions deploy-helm/flux-helm-release-crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,8 @@ spec:
format: int64
resetValues:
type: boolean
skipDepUpdate:
yinzara marked this conversation as resolved.
Show resolved Hide resolved
type: boolean
valueFileSecrets:
type: array
properties:
Expand Down
3 changes: 3 additions & 0 deletions integrations/apis/flux.weave.works/v1beta1/types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,9 @@ type HelmReleaseSpec struct {
// Reset values on helm upgrade
// +optional
ResetValues bool `json:"resetValues,omitempty"`
// Do not run 'dep' update (assume requirements.yaml is already fulfilled)
// +optional
SkipDepUpdate bool `json:"skipDepUpdate,omitempty"`
}

// GetTimeout returns the install or upgrade timeout (defaults to 300s)
Expand Down
2 changes: 1 addition & 1 deletion integrations/helm/chartsync/chartsync.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,7 +327,7 @@ func (chs *ChartChangeSync) reconcileReleaseDef(fhr fluxv1beta1.HelmRelease) {
chs.setCondition(&fhr, fluxv1beta1.HelmReleaseChartFetched, v1.ConditionTrue, ReasonCloned, "successfully cloned git repo")
chartPath = filepath.Join(chartClone.export.Dir(), chartSource.Path)

if chs.config.UpdateDeps {
if chs.config.UpdateDeps && !fhr.Spec.SkipDepUpdate {
if err := updateDependencies(chartPath, ""); err != nil {
chs.setCondition(&fhr, fluxv1beta1.HelmReleaseReleased, v1.ConditionFalse, ReasonDependencyFailed, err.Error())
chs.logger.Log("warning", "Failed to update chart dependencies", "namespace", fhr.Namespace, "name", fhr.Name, "error", err)
Expand Down