This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Wait for shutdown before returning from main() #1789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanprodan
approved these changes
Mar 4, 2019
|
In the Helm operator main.go, I recanted this defer thing and just moved the blocking code to the end of the procedure. I'd be happy with that here as well. |
This is more idiomatic Go and less likely to lead to subtle bugs.
bboreham
force-pushed
the
dont-stop-dnsing
branch
from
cf9102e
to
f0ab7f1
Compare
bboreham
changed the title
|
I updated my PR to just wait at the end of |
squaremo
approved these changes
Mar 4, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1788
Currently,
memcachedClient.Stop()is getting called at the beginning of the run, on return frommain(), which breaks things if the cache moves address.Personally I find this style too confusing and would just wait at the end ofmain(), but this looks like a trivial fix.