This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Support different targetNamespace for HelmRelease #2128 #2334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanprodan
suggested changes
Aug 8, 2019
"might" -- what would decide one way of the other? |
|
The new field is opt-in and it doesn't change the default behaviour, so I would keep the version as it is since we'll be releasing v1 after the repo split. |
stefanprodan
approved these changes
Aug 12, 2019
stefanprodan
force-pushed
the
targetNamespace_2128
branch
from
19d7a97
to
b94ffe9
Compare
6 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2128
I've tested this on a kind cluster with several cases.
Let me know if we should add some e2e tests.
We might also need to bump the CRD to
v1beta2.