This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Add AWS China region domain to recognized ECR hosts #2982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiddeco
force-pushed
the
aws-partition-domains
branch
2 times, most recently
from
138a98f
to
d316e04
Compare
AWS has regions and services in different partitions, all partitions seem to use a .com hostname except for the "aws-cn" region that uses .com.cn. This hostname was not taken into account, resulting in Flux being unable to pull image metadata in the China region. https://github.com/aws/aws-sdk-go/blob/d232400/aws/endpoints/defaults.go
hiddeco
force-pushed
the
aws-partition-domains
branch
from
8cdca51
to
f62529f
Compare
hiddeco
changed the title
squaremo
reviewed
Apr 14, 2020
| @@ -51,6 +54,15 @@ func contains(strs []string, str string) bool { | |||
| return false | |||
| } | |||
|
|
|||
| func validECRHost(domain string) bool { | |||
| switch { | |||
| case strings.HasSuffix(domain, awsPartitionSuffix): | |||
There was a problem hiding this comment.
No implicit fallthrough in Go!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2964.