Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Add guide to use GKE workload identity with private GCR registry #3023

Merged
merged 5 commits into from
May 12, 2020

Conversation

marratj
Copy link
Contributor

@marratj marratj commented Apr 24, 2020

This PR is for adding a guide to the docs on how to configure the Flux service account for use with GKE Workload Identity if using a private Google Container Registry.

When Workload Identity is enabled and private images are being used for workloads in the cluster, Flux needs to be authenticated against GCR (actually the GCS bucket beneath it) to be able to scan for new images.

This is a guide that "fixes" #2379

@marratj
Copy link
Contributor Author

marratj commented May 6, 2020

@hiddeco care to review? :-)

@hiddeco
Copy link
Member

hiddeco commented May 6, 2020

@marratj won’t be before Monday next week as I am enjoying time off.

Copy link
Member

@hiddeco hiddeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The guide is detailed but easy to follow! 💯

To actually make it appear in the guides menu you need to add an entry to mkdocs.yaml.

@marratj marratj force-pushed the gke-workload-identity-docs branch from 4cecf31 to 4f9d866 Compare May 12, 2020 08:22
Copy link
Member

@hiddeco hiddeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🛰️

@hiddeco hiddeco force-pushed the gke-workload-identity-docs branch from e8188ca to 9b153b9 Compare May 12, 2020 09:24
@hiddeco hiddeco added the docs Issue or PR relates to documentation label May 12, 2020
@hiddeco hiddeco force-pushed the gke-workload-identity-docs branch from 9b153b9 to aedc807 Compare May 12, 2020 10:16
@hiddeco hiddeco force-pushed the gke-workload-identity-docs branch from aedc807 to 28655d6 Compare May 12, 2020 10:16
@hiddeco hiddeco merged commit 4692086 into fluxcd:master May 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
docs Issue or PR relates to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants