Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

build fluxctl snap using GH action #3072

Merged
merged 2 commits into from
May 26, 2020
Merged

build fluxctl snap using GH action #3072

merged 2 commits into from
May 26, 2020

Conversation

dholbach
Copy link
Member

@dholbach dholbach commented May 22, 2020

Retrying #3034 after reading samuelmeuli/action-snapcraft#11 (comment)

Build snap using GH action... next steps:

  • confirm build works
  • add secrets to access snap store
  • commits to master: publish in edge channel
  • releases: publish in stable channel

@dholbach
Copy link
Member Author

https://github.com/dholbach/flux/runs/699917271 looks good! :-)

@dholbach dholbach self-assigned this May 22, 2020
@dholbach dholbach changed the title build snap build snap using GH action May 22, 2020
@dholbach dholbach changed the title build snap using GH action build fluxctl snap using GH action May 22, 2020
@dholbach
Copy link
Member Author

✔️ https://github.com/dholbach/flux/runs/708796834 (with snapcraft_token added to my repo too).

@dholbach dholbach marked this pull request as ready for review May 26, 2020 09:52
@dholbach dholbach added the build About the build or test scaffolding label May 26, 2020
@dholbach
Copy link
Member Author

To add some background: for every commit to master, this GH Action workflow

  • builds the snap using snap/snapcraft.yaml
  • if it's a tagged release, upload the resulting snap to the stable channel of the snap
  • if not, upload the resulting snap to the edge channel

Up until now I did this all manually (for releases and for commits in master every other day), because we were blocked by canonical-web-and-design/build.snapcraft.io#1191 (to set up the webhook automatically, build.snapcraft.io wanted very broad privileges).

This would automate it all away.

	For every commit to master, this GH Action workflow

	- builds the snap using snap/snapcraft.yaml
	- if it's a tagged release, upload the resulting snap to the stable channel of the snap
	- if not, upload the resulting snap to the edge channel
Copy link
Member

@squaremo squaremo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the basis that I this demonstrably works, and I can see how to debug it when it doesn't, I approve this PR. Thanks Daniel! 🍍

@dholbach
Copy link
Member Author

	ERROR	https://man7.org/linux/man-pages/man5/ssh_config.5.html
		X509: certificate signed by unknown authority

Firefox says it's "Let's Encrypt". 🤷

@dholbach
Copy link
Member Author

I guess I can just exclude man7.org from being checked?

@hiddeco
Copy link
Member

hiddeco commented May 26, 2020

@dholbach it might also be solved by updating the ca-certificates package in the docs.yaml GitHub Action.

@dholbach
Copy link
Member Author

💡

@dholbach
Copy link
Member Author

Apparently it was already installed, so I'll remove it again and exclude man7.org.

@dholbach dholbach merged commit 6eef073 into fluxcd:master May 26, 2020
@dholbach dholbach deleted the build-snap-using-gh-action branch May 26, 2020 16:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
build About the build or test scaffolding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants