This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Upgrade json-patch to v4.9.0 #3373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stefan Sedich <stefan.sedich@gmail.com>
stefansedich
force-pushed
the
upgrade-json-patch
branch
from
ce2f1aa
to
3c4abc7
Compare
squaremo
approved these changes
Nov 25, 2020
There was a problem hiding this comment.
Looks straight-forward and reasonable to me. (And passes tests)
Thank you @stefansedich 🍰
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades json-patch to v4.9.0 to fix the issues we are experiencing after upgrading to cert-manager 1.x, we began to see lockups in the sync-loop attempting to perform image upgrades.
This thread sums up the issues experienced https://cloud-native.slack.com/archives/CLAJ40HV3/p1601469463086700 by both myself and another user when flux experiences image upgrades with the cert-manager CRDs being present.
After some digging I saw that Flux is using the version of json-patch (v4.5.0) before the fixes (v4.6.0) addressing the exponential complexity for nested objects kubernetes/kubernetes#91615 which was causing issues with the cert-manager CRDs.
After upgrading json-patch to 4.9.0 and running a custom build of flux in our cluster everything is happy again and our upgrades are no longer blocking the sync loop. It would be nice if we could get the PR merged and a release pushed so that others do not experience this issue.