Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Update dependencies #3597

Merged
merged 8 commits into from
Mar 29, 2022
Merged

Update dependencies #3597

merged 8 commits into from
Mar 29, 2022

Conversation

kingdonb
Copy link
Member

@kingdonb kingdonb commented Mar 29, 2022

Fix #3587

Only the upgrades which did not seem to break anything, when I was testing at kingdonb/flux – I accepted basically every suggestion from Renovate bot, except for client-go which is blocked from upgrading until there are no supported K8s releases that remain in service, that can still work on non-v1 CRD. Flux must support those v1.21 and earlier as long as they are in use to remain backwards compatible.

NB: it is still possible that I have broken something, it is difficult to tell flaky tests from actual failing tests. I will follow up on any failing tests, but I also need help from users to know if there are failures that weren't covered by any tests. (I'm sure you'll tell me!)

I am working on a local test scaffold so that I can see whether the tests pass or fail when ran against a local instance, although I have learned it's possible to get an SSH session to test failures when they happen at CircleCI, I am not sure if that will help, if the issue is transient or not, I should be able to reproduce it locally just as well.

@kingdonb kingdonb added this to the 1.25.0 milestone Mar 29, 2022
@kingdonb
Copy link
Member Author

@stefanprodan Please let me know if you would find anything problematic or if anything important is missing here! 🙏

@kingdonb
Copy link
Member Author

I will have to follow up and investigate:

ci / e2e-testing (13_* 14_*) (pull_request) Failing after 6m — e2e-testing (13_* 14_*)

This failure seems to be consistent, and might have been caused through one of these upgrades.

Kingdon Barrett and others added 7 commits March 29, 2022 08:30
This will probably not work

Update github.com/weaveworks/common digest to 00e2e23

Signed-off-by: Kingdon Barrett <kingdon@weave.works>
Signed-off-by: Kingdon Barrett <kingdon@weave.works>
Signed-off-by: Kingdon Barrett <kingdon@weave.works>
go mod download

Signed-off-by: Kingdon Barrett <kingdon@weave.works>
Update module github.com/docker/distribution to v2.8.1
Update module github.com/gorilla/websocket to v1.5.0
Update golang.org/x/oauth2 digest to 6242fa9
Update module github.com/fluxcd/helm-operator to v1.4.2
Update module github.com/google/go-containerregistry to v0.8.0
Update module github.com/fluxcd/distribution to v2

Signed-off-by: Kingdon Barrett <kingdon@weave.works>
This reverts commit 17e9c53.

go mod download, go mod tidy

Signed-off-by: Kingdon Barrett <kingdon@weave.works>
Signed-off-by: Kingdon Barrett <kingdon@weave.works>

update sops checksum

Signed-off-by: Kingdon Barrett <kingdon@weave.works>
This partially reverts commit 8ea1545.

Signed-off-by: Kingdon Barrett <kingdon@weave.works>
@kingdonb
Copy link
Member Author

kingdonb commented Mar 29, 2022

In: 83132d3

I reverted the upgrade to weaveworks/common which was apparently a lucky guess – I think I've seen this failure before in a prior attempt to upgrade everything, so maybe just good memory... and it seems this fixes the e2e-testing (13_* 14_*) failures that were in the first attempt at passing this PR.

I've rebased and signed off in ef1cfe7, going to run the tests again (and hopefully we see that e2e 13,14 are consistently passing now, instead of consistently failing.)

@kingdonb
Copy link
Member Author

This looks to be passing, (now really ready for review.)

@stefanprodan stefanprodan changed the title Update everything Update dependencies Mar 29, 2022
@stefanprodan stefanprodan added the build About the build or test scaffolding label Mar 29, 2022
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @kingdonb

@kingdonb kingdonb merged commit 0e9e889 into master Mar 29, 2022
@kingdonb kingdonb deleted the update-everything branch March 29, 2022 14:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
build About the build or test scaffolding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Snyk - Flagged warnings in the base image
3 participants