This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Allow RSA signatures using SHA-1 hash algorithm #3614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was disabled by default at openssh 8.8 but is still used by some git implementations eg Azure DevOps Signed-off-by: David Hotham <david.hotham@microsoft.com>
|
I will take your word for it that our images before 1.25.0 did not have this regression, and this is the correct fix. I have not been using either Azure DevOps or Google Code Repository so I haven't seen this behavior in any of my testing. I think that SHA-1 was deprecated for a reason, but in Flux v1 there is a backwards compatibility guarantee, we should not have broken this. I think we should find a way with gitsrv to emulate the described SHA-1 signature behavior and reproduce the issue in a test, so that we can guarantee it does not reoccur in future updates. 👍 Thanks for the contribution @dimbleby ! |
2 tasks
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was disabled by default at openssh 8.8 but is still used by some git implementations eg Azure DevOps
Fixes #3611
Per that issue, would welcome a release containing this fix - flux 1.25.0 is meanwhile not usable for us.