Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add OCI support to create source helm #2781

Merged
merged 3 commits into from
Jun 1, 2022
Merged

Add OCI support to create source helm #2781

merged 3 commits into from
Jun 1, 2022

Conversation

makkes
Copy link
Member

@makkes makkes commented May 28, 2022 •
edited

This needs to be updated as soon as we have an SC release that ships the new type field in the HelmRepository CRD.

closes #2774

@makkes makkes self-assigned this May 28, 2022
@makkes makkes added area/helm Helm related issues and pull requests area/oci OCI related issues and pull requests labels May 28, 2022
@makkes makkes force-pushed the create-source-helm-oci branch 2 times, most recently from 9038b8e to 0430b7d Compare May 28, 2022 16:46
souleb
souleb reviewed May 31, 2022
View reviewed changes
cmd/flux/create_source_helm.go Outdated Show resolved Hide resolved
cmd/flux/create_source_helm.go Outdated Show resolved Hide resolved
@souleb
Copy link
Member

souleb commented May 31, 2022 •
edited

we use stringData in the underlying secret... We should use data format. edit: this is just a comment for future work as we have encountered bugs in the past with stringData

@makkes
Copy link
Member Author

makkes commented May 31, 2022

rebased and addressed comments

@souleb
Copy link
Member

souleb commented May 31, 2022

flux create secret helm should be extended to support dockerconfig as a follow up work.

@stefanprodan
Copy link
Member

flux create secret helm should be extended to support dockerconfig as a follow up work.

I would not do that, after we implement OCI support for Kubernetes manifests, we would add flux create secret oci that would result in a dockerconfig secret type.

@makkes makkes marked this pull request as ready for review June 1, 2022 12:20
@makkes makkes mentioned this pull request Jun 1, 2022
Closed
Add OCI support to create source helm
e19ea79 
closes #2774

Signed-off-by: Max Jonas Werner <mail@makk.es>
bump SC version in azure test module
7d74292 
Signed-off-by: Max Jonas Werner <mail@makk.es>
@makkes makkes requested a review from souleb June 1, 2022 14:07
souleb
souleb approved these changes Jun 1, 2022
View reviewed changes
Copy link
Member

@souleb souleb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@makkes makkes requested a review from hiddeco June 1, 2022 15:16
stefanprodan
stefanprodan approved these changes Jun 1, 2022
View reviewed changes
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @makkes 🏅

@stefanprodan stefanprodan merged commit b84e613 into main Jun 1, 2022
@stefanprodan stefanprodan deleted the create-source-helm-oci branch June 1, 2022 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanprodan stefanprodan stefanprodan approved these changes

@souleb souleb souleb approved these changes

@hiddeco hiddeco Awaiting requested review from hiddeco

Assignees

@makkes makkes

Labels
area/helm Helm related issues and pull requests area/oci OCI related issues and pull requests
Projects
Maintainers' Focus
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add OCI support to flux create source helm
3 participants
@makkes @souleb @stefanprodan