Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OCI support to flux create source helm #2774

Closed
makkes opened this issue May 27, 2022 · 0 comments · Fixed by #2781
Closed

Add OCI support to flux create source helm #2774

makkes opened this issue May 27, 2022 · 0 comments · Fixed by #2781
Assignees
Labels
area/helm Helm related issues and pull requests area/oci OCI related issues and pull requests
Milestone

Comments

@makkes
Copy link
Member

makkes commented May 27, 2022

With fluxcd/source-controller#690, source-controller gained the ability to consume Helm charts from OCI registries. The CLI should support creating OCI-type HelmRepositories, too. The type is inferred from the URL:

flux create source helm --url=oci://...

will create a HelmRepository with the .spec.type field set to oci.

The example section of flux create source helm --help should include an example for creating an OCI HelmRepository including explanation of dockerconfigjson Secrets referenced in --secret-ref.

@makkes makkes added area/helm Helm related issues and pull requests area/oci OCI related issues and pull requests labels May 27, 2022
@makkes makkes self-assigned this May 27, 2022
@makkes makkes added this to the GA milestone May 27, 2022
makkes pushed a commit that referenced this issue May 28, 2022
closes #2774

Signed-off-by: Max Jonas Werner <mail@makk.es>
makkes pushed a commit that referenced this issue May 28, 2022
closes #2774

Signed-off-by: Max Jonas Werner <mail@makk.es>
makkes pushed a commit that referenced this issue May 28, 2022
closes #2774

Signed-off-by: Max Jonas Werner <mail@makk.es>
makkes pushed a commit that referenced this issue May 31, 2022
closes #2774

Signed-off-by: Max Jonas Werner <mail@makk.es>
makkes pushed a commit that referenced this issue May 31, 2022
closes #2774

Signed-off-by: Max Jonas Werner <mail@makk.es>
makkes pushed a commit that referenced this issue Jun 1, 2022
closes #2774

Signed-off-by: Max Jonas Werner <mail@makk.es>
makkes pushed a commit that referenced this issue Jun 1, 2022
closes #2774

Signed-off-by: Max Jonas Werner <mail@makk.es>
bmelbourne pushed a commit to bmelbourne/flux2 that referenced this issue Jun 3, 2022
closes fluxcd#2774

Signed-off-by: Max Jonas Werner <mail@makk.es>
souleb pushed a commit to souleb/flux2 that referenced this issue Jul 10, 2023
closes fluxcd#2774

Signed-off-by: Max Jonas Werner <mail@makk.es>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/helm Helm related issues and pull requests area/oci OCI related issues and pull requests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant