Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update actions/setup-go in workflows to v4.0.0 #3709

Closed
9 tasks done
hiddeco opened this issue Mar 20, 2023 · 0 comments
Closed
9 tasks done

Update actions/setup-go in workflows to v4.0.0 #3709

hiddeco opened this issue Mar 20, 2023 · 0 comments
Labels
area/ci CI related issues and pull requests umbrella-issue Umbrella issue for tracking progress of a larger effort

Comments

@hiddeco
Copy link
Member

hiddeco commented Mar 20, 2023 •
edited by stefanprodan
Loading

We should update actions/setup-go in our workflows to v4.0.0, which comes with the enabling of Go Modules caching by default.

By properly configuring this, we can reduce maintenance overhead and remove our dependency on actions/cache in most of our workflows. See the below linked PRs for examples of the required changes.

To-do
@hiddeco hiddeco added area/ci CI related issues and pull requests umbrella-issue Umbrella issue for tracking progress of a larger effort labels Mar 20, 2023
@hiddeco hiddeco mentioned this issue Mar 21, 2023
Merged
@hiddeco hiddeco mentioned this issue Mar 29, 2023
Merged
kingdonb pushed a commit to kingdonb/podinfo that referenced this issue Apr 6, 2023
Change to use release.yml from upstream podinfo
7496b01 
The only modification is to use actions/setup-go@v4 (which supposedly
contains a caching feature that gets enabled by default!)

fluxcd/flux2#3709

This release workflow is more advanced than the one we were using, that
was adapted from https://fluxcd.io/flux/use-cases/gh-actions-app-builder/

This does away with the manual approval that we were using, from:
trstringer/manual-approval@v1

There are numerous spots where the org name "stefanprodan" should be
replaced, (we'll do that in a following commit before pushing this up)

Signed-off-by: Kingdon Barrett <kingdon@weave.works>
@stefanprodan stefanprodan mentioned this issue May 10, 2023
Merged
This was referenced May 25, 2023
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/ci CI related issues and pull requests umbrella-issue Umbrella issue for tracking progress of a larger effort
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stefanprodan @hiddeco