Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement check, install, uninstall and create source commands #1

Merged
merged 15 commits into from
Apr 25, 2020
Merged

Implement check, install, uninstall and create source commands #1

merged 15 commits into from
Apr 25, 2020

Conversation

stefanprodan
Copy link
Member

@stefanprodan stefanprodan commented Apr 24, 2020 •
edited

Changes:

  • add check command
    • kubectl >=1.18.0
    • kustomize >=3.5.0
    • kubernetes >=1.14.0
  • add install manifests
    • RBAC role for CRs
    • RBAC cluster role for kustomize reconciler
    • deny ingress network policy
  • add install command with dry-run option
  • add uninstall command with dry-run option
    • prompt for confirmation
  • add create source command for Git repositories
    • generate secret for basic-auth credentials
    • generate SSH host and deploy keys
    • generate secret for SSH keys
    • prompt for deploy key setup
  • add end-to-end tests for:
    • check
    • install (local manifests)
    • create source (public repository)

@stefanprodan
Add install manifests
42d2ed5
@stefanprodan
Add install command with dry-run option
94e0b3c 
- build kustomization
- apply output on the cluster
- check rollout status of source and kustomize controllers
@stefanprodan
Add check command
403a0f2 
- verify minimum supported version of kubectl, kustomize and
Kubernetes API
@stefanprodan stefanprodan changed the title Implement install command Implement check and install commands Apr 24, 2020
@stefanprodan stefanprodan force-pushed the install branch 4 times, most recently from df21dd8 to e128780 Compare April 24, 2020 17:26
@stefanprodan stefanprodan force-pushed the install branch 3 times, most recently from 780672b to 9c09588 Compare April 24, 2020 17:53
@stefanprodan
Implement create source for ssh git repos
1371b4d 
- generate host keys and SSH keys
- prompt for deploy key setup
- generate gitrepo source
- wait for source to sync
@stefanprodan stefanprodan changed the title Implement check and install commands Implement check, install, create source commands Apr 24, 2020
hiddeco
hiddeco approved these changes Apr 25, 2020
View reviewed changes
cmd/tk/create_source.go

logAction("generating deploy key")

keygen := fmt.Sprintf("ssh-keygen -b 2048 -t rsa -f %s/identity -q -N \"\"", tmpDir)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be done without depending on ssh-keygen using one of the crypto packages.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we want to get rid of openssh we need to replace keyscan as well. We could generate the host keys with something like https://github.com/Eun/sshkeys/blob/master/sshkeys.go

@stefanprodan stefanprodan changed the title Implement check, install, create source commands Implement check, install, uninstall and create source commands Apr 25, 2020
@stefanprodan stefanprodan merged commit 38cc918 into master Apr 25, 2020
@stefanprodan stefanprodan deleted the install branch April 25, 2020 16:49
@davidkarlsen davidkarlsen mentioned this pull request Feb 22, 2021
Closed
@allenporter allenporter mentioned this pull request Aug 17, 2021
Merged
@ilijamt ilijamt mentioned this pull request Oct 31, 2022
Open
1 task
ybelleguic pushed a commit to ybelleguic/flux2 that referenced this pull request Jan 9, 2023
@stefanprodan
Merge pull request fluxcd#1 from fluxcd/ci-e2e
a55cae2 
Implement CI with GitHub Actions
@lakshman-au lakshman-au mentioned this pull request Sep 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiddeco hiddeco hiddeco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stefanprodan @hiddeco