Make manifests dir bundle.sh configurable
#1066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was an assumption in this script that it is always executed in Git repository/directory, this is however not always true, for example when one downloads the `.tar.gz` that is made available for every release by GitHub (and used in one of our AUR packages). This commit changes this, and makes the first argument of `bundle.sh` configurable, so a custom manifests directory can always be defined _without_ relying on Git. Omitting it, or passing an empty string, will still fall back to the previous behavior of using `git rev-parse --show-toplevel`. Signed-off-by: Hidde Beydals <hello@hidde.co>
hiddeco
commented
Mar 8, 2021
This commit makes a couple of changes to the `flux-{go,scm}` packages
so that they properly build again:
- The manifests are generated before the compilation of the `flux`
binary.
- The `makedepends` have been updated to require a version of Go
`>=1.16` (which is a requirement for `embed`).
- The `makedepends` have been updated to require a `kustomize` version
`>=3.0` (as we use `transformers`).
Signed-off-by: Hidde Beydals <hello@hidde.co>
hiddeco
force-pushed
the
manifest-bundle-tweaks
branch
from
c620277
to
5fd3d0b
Compare
stefanprodan
approved these changes
Mar 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an assumption in this script that it is always executed in Git
repository/directory, this is however not always true, for example when
one downloads the
.tar.gzthat is made available for every releaseby GitHub (and used in one of our AUR packages).
This commit changes this, and makes the first argument of
bundle.shconfigurable, so a custom manifests directory can always be defined
without relying on Git.
Omitting it, or passing an empty string, will still fall back to the
previous behavior of using
git rev-parse --show-toplevel.