Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Host from parsed URL instead of Hostname #1102

Merged
merged 1 commit into from
Mar 16, 2021
Merged

Use Host from parsed URL instead of Hostname #1102

merged 1 commit into from
Mar 16, 2021

Conversation

hiddeco
Copy link
Member

@hiddeco hiddeco commented Mar 16, 2021

Fixes #1101.

@hiddeco
Use Host from parsed URL instead of Hostname
dc6b0d0 
Regression bug introduced in #1001.

Signed-off-by: Hidde Beydals <hello@hidde.co>
@hiddeco hiddeco added bug Something isn't working area/bootstrap Bootstrap related issues and pull requests labels Mar 16, 2021
@hiddeco hiddeco merged commit 0b69695 into main Mar 16, 2021
@hiddeco hiddeco deleted the fix-sshscan-port branch March 16, 2021 13:17
@tjakobsson tjakobsson mentioned this pull request May 4, 2021
Closed
tjakobsson added a commit to tjakobsson/flux2 that referenced this pull request May 4, 2021
@tjakobsson
Use proper Host configuration for SSH
12883c6 
This removes the usage of Hostname() which does not honor configured SSH
port to be used.

Resolves: fluxcd#1377
See also: fluxcd#1101, fluxcd#1102

Signed-off-by: Tobias Jakobsson <jakobsson.tobias@gmail.com>
@tjakobsson tjakobsson mentioned this pull request May 4, 2021
Merged
tjakobsson added a commit to tjakobsson/flux2 that referenced this pull request May 10, 2021
@tjakobsson
Use proper Host configuration for SSH
ea62cb5 
This removes the usage of Hostname() which does not honor configured SSH
port to be used.

Resolves: fluxcd#1377
See also: fluxcd#1101, fluxcd#1102

Signed-off-by: Tobias Jakobsson <jakobsson.tobias@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanprodan stefanprodan stefanprodan approved these changes

Assignees
No one assigned
Labels
area/bootstrap Bootstrap related issues and pull requests bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flux CLI : creating SSH GitRepository with port != 22 fails
2 participants
@hiddeco @stefanprodan