Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add push branch and commit template to image automation guide #1117

Merged
merged 2 commits into from
Mar 18, 2021

Conversation

stefanprodan
Copy link
Member

@stefanprodan stefanprodan commented Mar 18, 2021

Changes to the image automation guide:

Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
@stefanprodan stefanprodan added area/docs Documentation related issues and pull requests area/image-automation Automated image updates related issues and pull requests labels Mar 18, 2021
--author-name=fluxcdbot \
--author-email=fluxcdbot@users.noreply.github.com \
--commit-template="[ci skip] update image" \
--commit-template="{{range .Updated.Images}}{{println .}}{{end}}" \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change removes the [ci skip] example, is that done on purpose, and if so, do we want to highlight this elsewhere?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think people should skip CI when pushing changes to the repo made with flux bootstrap.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
@stefanprodan stefanprodan merged commit 3dfd0bc into main Mar 18, 2021
@stefanprodan stefanprodan deleted the update-image-auto-guide] branch March 18, 2021 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs Documentation related issues and pull requests area/image-automation Automated image updates related issues and pull requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants