Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add recurse submodules arg to create source git and bootstrap cmd #1191

Merged
merged 3 commits into from
Apr 7, 2021
Merged

Add recurse submodules arg to create source git and bootstrap cmd #1191

merged 3 commits into from
Apr 7, 2021

Conversation

stefanprodan
Copy link
Member

@stefanprodan stefanprodan commented Apr 1, 2021 •
edited

Changes to flux create source git command:

  • Add --recurse-submodules boolean arg
  • Allow recurse submodules only when --git-implementation=go-git
  • Allow self-signed certs for both go-git and libgit2

Changes to flux bootstrap commands:

  • Add --recurse-submodules boolean arg

@stefanprodan stefanprodan added enhancement New feature or request area/git Git related issues and pull requests labels Apr 1, 2021
@stefanprodan
Allow self-signed certs when using go-git
8f0cd35 
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
@stefanprodan
Add recurse submodules arg to create source git cmd
18c3f79 
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
@stefanprodan stefanprodan changed the title Add recurse submodules arg to create source git cmd Add recurse submodules arg to create source git and bootstrap cmd Apr 7, 2021
@stefanprodan stefanprodan added the area/bootstrap Bootstrap related issues and pull requests label Apr 7, 2021
hiddeco
hiddeco reviewed Apr 7, 2021
View reviewed changes
cmd/flux/bootstrap.go Outdated Show resolved Hide resolved
@stefanprodan
Add recurse submodules arg to bootstrap cmd
b872e59 
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
hiddeco
hiddeco reviewed Apr 7, 2021
View reviewed changes
Copy link
Member

@hiddeco hiddeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @stefanprodan 💯

@stefanprodan stefanprodan merged commit 58362fb into main Apr 7, 2021
@stefanprodan stefanprodan deleted the recurse-submodules branch April 7, 2021 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiddeco hiddeco hiddeco approved these changes

Assignees
No one assigned
Labels
area/bootstrap Bootstrap related issues and pull requests area/git Git related issues and pull requests enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stefanprodan @hiddeco