Add support for password protected SSH keys to bootstrap #1264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiddeco
reviewed
Apr 14, 2021
There was a problem hiding this comment.
For the keys we test, we may want to start piggy backing of https://github.com/golang/crypto/blob/master/ssh/testdata/keys.go, as this has a broad range of (non-)encrypted key formats.
|
@somtochiama @hiddeco what's the status of this PR? |
|
It is blocked by a source-controller release and should be merged before the next MINOR release. |
stefanprodan
added
area/git
Signed-off-by: Somtochi Onyekwere <somtochionyekwere@gmail.com>
stefanprodan
changed the title
stefanprodan
added
area/bootstrap
stefanprodan
approved these changes
Apr 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Somtochi Onyekwere somtochionyekwere@gmail.com