Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix infrastructure clean up on Azure e2e test failure #1970

Merged
merged 1 commit into from
Oct 20, 2021

Conversation

phillebaba
Copy link
Member

This change fixes the defer to make sure that the infrastructure is destroyed before ending the test. Additionally it adds a check that the state is clean before running the test, as running the tests from an already existing cluster may cause issues for the test.

@phillebaba phillebaba changed the title Fix infrastructure clean up on test failure Fix infrastructure clean up on Azure e2e test failure Oct 20, 2021
Signed-off-by: Philip Laine <philip.laine@xenit.se>
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @phillebaba

@phillebaba phillebaba merged commit 6ee4abe into main Oct 20, 2021
@phillebaba phillebaba deleted the fix/azure-e2e-cleanup branch October 20, 2021 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants