Install envtest before running the unit tests #1976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
stefanprodan
added
area/docs
hiddeco
reviewed
Oct 21, 2021
| @@ -58,6 +58,10 @@ install: | |||
| install-dev: | |||
| CGO_ENABLED=0 go build -o /usr/local/bin ./cmd/flux | |||
|
|
|||
|
|
|||
| install-envtest: setup-envtest | |||
There was a problem hiding this comment.
I would maybe call this config-envtest, as I currently would kind of expect based on the target name that it does what setup-envtest does.
There was a problem hiding this comment.
This matches what's in kustomize-controller Makefile. I think we should normalise our Makefiles everywhere at some point.
There was a problem hiding this comment.
I think we should merge the 2 into install-envtest which downloads the envtest binary then installs the api and ectd ones.
hiddeco
approved these changes
Oct 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new command to Makefile for installing the envtest binaries (kube-api-server and etcd) before running the unit tests.
Fix: #1974