Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diff: Update homeport/Dyff to v1.5.2 #2584

Merged
merged 1 commit into from
Mar 29, 2022

Conversation

souleb
Copy link
Member

@souleb souleb commented Mar 28, 2022

If implemented, this will provide an inline diff for configmaps with the command flux diff.

possibly fixes #2400
Signed-off-by: Soule BA soule@weave.works

@souleb souleb added the area/diff Diff related issues and pull requests label Mar 28, 2022
@souleb souleb changed the title Update homeport/Dyff to v1.5.2 Diff: Update homeport/Dyff to v1.5.2 Mar 28, 2022
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @souleb please rebase

If implmented, this will provide an inline diff for configmaps with the
command `flux diff``.

Signed-off-by: Soule BA <soule@weave.works>
@stefanprodan stefanprodan merged commit e2be598 into fluxcd:main Mar 29, 2022
@stefanprodan stefanprodan deleted the update-homeport-dyff branch March 29, 2022 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/diff Diff related issues and pull requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flux diff could provide an inline diff for large configmap entries
2 participants