kustomize: use FS from fluxcd/pkg
#2651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiddeco
added
the
area/kustomization
hiddeco
force-pushed
the
customize-kustomize-fs
branch
from
fc4fe70
to
3f1b920
Compare
|
We need to postpone this until @stefanprodan is back next week, as I currently can't steer around some of the assumptions (and lack of a root argument) in some of the generating parts of the API. |
stefanprodan
force-pushed
the
customize-kustomize-fs
branch
from
ca77155
to
c2041fe
Compare
hiddeco
force-pushed
the
customize-kustomize-fs
branch
3 times, most recently
from
6f9850f
to
2e6f576
Compare
hiddeco
added
area/bootstrap
hiddeco
force-pushed
the
customize-kustomize-fs
branch
from
2e6f576
to
b6c8dea
Compare
hiddeco
force-pushed
the
customize-kustomize-fs
branch
2 times, most recently
from
c24ae3b
to
0259bc0
Compare
This switches to a secure FS implementation in most places, except for where we can not make changes at this moment because it would break behavior. Not handled in this commit: - Allowing the root for `manifestgen` packages to be configured. - Allowing the user to define a working root while building locally. - Defaulting to the secure FS implementation in `kustomization.MakeDefaultOptions`. Problem here is that constructing the secure FS could result in an error, which we can not surface without signature changes to the constructor func. Signed-off-by: Hidde Beydals <hello@hidde.co>
hiddeco
force-pushed
the
customize-kustomize-fs
branch
from
0259bc0
to
57442e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches to a secure FS implementation in most places, except for
where we can not make changes at this moment because it would break
behavior.
Not handled in this commit:
manifestgenpackages to be configured.kustomization.MakeDefaultOptions. Problem here is that constructingthe secure FS could result in an error, which we can not surface
without signature changes to the constructor func.