Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MacOS: fix bootstrap manifest generation #2700

Merged
merged 1 commit into from
May 4, 2022
Merged

Conversation

stefanprodan
Copy link
Member

Use the OS package to write the generated files on disk instead of Flux secure FS package which is meant for read operations.

Fix: #2699

Use the OS package to write the generated files on disk instead of Flux  secure FS package which is meant for read operations.

Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
@stefanprodan stefanprodan added the area/bootstrap Bootstrap related issues and pull requests label May 4, 2022
@stefanprodan stefanprodan requested a review from hiddeco May 4, 2022 06:41
@aryan9600
Copy link
Member

I think a better fix would be to resolve symlinks for temp dirs, refer to: https://github.com/fluxcd/kustomize-controller/pull/630/files

@stefanprodan
Copy link
Member Author

@aryan9600 os.WriteFile is used for all the other file generators except for this one. Switching to SecureFS for all write operations could be done in a different PR.

@hiddeco hiddeco changed the title Fix bootstrap manifest generation MacOS: fix bootstrap manifest generation May 4, 2022
@stefanprodan stefanprodan merged commit 4dd20af into main May 4, 2022
@stefanprodan stefanprodan deleted the fix-bootstrap-fs branch May 4, 2022 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/bootstrap Bootstrap related issues and pull requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cannot upgrade to 0.30.0 on macOS
3 participants