Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for multi-namespace tenant ownership #273

Merged
merged 1 commit into from Sep 28, 2020
Merged

Add support for multi-namespace tenant ownership #273

merged 1 commit into from Sep 28, 2020

Conversation

stefanprodan
Copy link
Member

@stefanprodan stefanprodan commented Sep 26, 2020 •
edited

Changes:

  • add --with-namespace arg to create tenant command
  • label namespaces and role bindings with the tenant name for discovery purposes
  • allow changing the the cluster role name with --cluster-role arg, defaults to cluster-admin
  • add create tenant examples to docs

Ref: #278

@stefanprodan stefanprodan added enhancement New feature or request area/multi-tenancy Multi-tenancy related issues and pull requests labels Sep 26, 2020
hiddeco
hiddeco approved these changes Sep 28, 2020
View reviewed changes
Copy link
Member

@hiddeco hiddeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stefanprodan stefanprodan merged commit 938edef into master Sep 28, 2020
@stefanprodan stefanprodan deleted the tenant-customization branch September 28, 2020 10:11
ybelleguic pushed a commit to ybelleguic/flux2 that referenced this pull request Jan 9, 2023
@hiddeco
Merge pull request fluxcd#273 from fluxcd/start-fs-on-leader-election
65bebeb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiddeco hiddeco hiddeco approved these changes

Assignees
No one assigned
Labels
area/multi-tenancy Multi-tenancy related issues and pull requests enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stefanprodan @hiddeco