Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --allow-insecure-http to bootstrap git #2787

Merged
merged 2 commits into from
Jun 2, 2022

Conversation

vipulnewaskar7
Copy link
Contributor

@vipulnewaskar7 vipulnewaskar7 commented May 30, 2022

This change will allow the end-user to bootstrap with HTTP git URLs
But the user must explicitly set --allow-insecure-http=true
Fix: #2786

Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase your branch with upstream main instead of merging.

This change will allow user to bootstrap with http git urls
But user must explicitely set --allow-insecure-http=true

Signed-off-by: Vipul Newaskar <vipulnewaskar7@gmail.com>
Updated misleading error message

Signed-off-by: Vipul Newaskar <vipulnewaskar7@gmail.com>
@vipulnewaskar7
Copy link
Contributor Author

vipulnewaskar7 commented Jun 2, 2022

Hi @stefanprodan
I have updated the misleading error message and rebased the main branch on my branch.

@stefanprodan stefanprodan changed the title Allow http git urls for bootstraping Add --allow-insecure-http to bootstrap git Jun 2, 2022
@stefanprodan stefanprodan added the area/bootstrap Bootstrap related issues and pull requests label Jun 2, 2022
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @vipulnewaskar7 🏅

@stefanprodan stefanprodan merged commit 56c5e78 into fluxcd:main Jun 2, 2022
@stefanprodan stefanprodan mentioned this pull request Jun 8, 2022
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/bootstrap Bootstrap related issues and pull requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow flux bootstrap with http git URLs
2 participants