Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make use of apis/meta helpers and improve reconcile logic #281

Merged
merged 2 commits into from Oct 1, 2020

Conversation

hiddeco
Copy link
Member

@hiddeco hiddeco commented Sep 30, 2020

Fixes #215 based on discussion in #217 (reply in thread)

@hiddeco hiddeco force-pushed the meta-reconciler-improv branch 3 times, most recently from 9fef5f8 to 21448e6 Compare October 1, 2020 12:08
@hiddeco hiddeco marked this pull request as ready for review October 1, 2020 12:18
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Nice refactoring 🥇

@hiddeco hiddeco merged commit 70d0bfc into master Oct 1, 2020
@hiddeco hiddeco deleted the meta-reconciler-improv branch October 1, 2020 12:31
ybelleguic pushed a commit to ybelleguic/flux2 that referenced this pull request Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve gotk reconcile helmrelease readiness check
2 participants