Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ARM instruction to get started guide #327

Merged
merged 1 commit into from
Oct 13, 2020

Conversation

nanikjava
Copy link
Contributor

@nanikjava nanikjava commented Oct 13, 2020

Issue : #306

ARM instruction are now added inside the doc. Below is screenshot how it looks like based on the PR changes.

Screenshot from 2020-10-13 13-45-23
Screenshot from 2020-10-13 13-45-33

@nanikjava
Copy link
Contributor Author

To run mkdocs using Docker following is the Dockerfile

FROM python:3.9
COPY ./mkdocs.yml/ /
COPY ./docs/ /mkdocs/
COPY ./docs/ /docs/
COPY ./CONTRIBUTING.md /
COPY ./CODE_OF_CONDUCT.md /
COPY ./LICENSE /
COPY ./MAINTAINERS /
WORKDIR /
RUN pip install mkdocs
RUN pip install mkdocs-material-extensions
EXPOSE 8080
CMD ["mkdocs", "serve","-f","mkdocs.yml","-a","0.0.0.0:8080"]
# mkdocs serve -f mkdocs.yml

Build the Dockerfile with the command

docker build -t mkdocs:latest .

and to run it

docker run -p 8888:8080  mkdocs:latest

Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can please remove the hint under production, one ARM reference is enough.

@nanikjava
Copy link
Contributor Author

Can please remove the hint under production, one ARM reference is enough.

@stefanprodan done

Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @nanikjava

@stefanprodan stefanprodan added the area/docs Documentation related issues and pull requests label Oct 13, 2020
@stefanprodan stefanprodan changed the title Add ARM instruction under staging and production bootstrap Add ARM instruction to get started guide Oct 13, 2020
@nanikjava
Copy link
Contributor Author

@stefanprodan do you mind adding the label `hacktoberfest-accepted' ? thank you.

@stefanprodan stefanprodan merged commit 13f7d44 into fluxcd:main Oct 13, 2020
@aledegano aledegano mentioned this pull request May 6, 2021
ybelleguic pushed a commit to ybelleguic/flux2 that referenced this pull request Jan 9, 2023
Add support for Git submodules with go-git
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs Documentation related issues and pull requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants