Get rid of shell-out and invoke command directly via exec #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmd/gotk/utils.go
Outdated
| @@ -62,7 +62,12 @@ const ( | |||
|
|
|||
| func (*Utils) execCommand(ctx context.Context, mode ExecMode, command string) (string, error) { | |||
There was a problem hiding this comment.
Can you please change the signature to:
execKubectlCommand(ctx context.Context, mode ExecMode, arg ...string) (string, error)There was a problem hiding this comment.
After the signature change we need to pass an args array, so the current string concatenation should be rewritten to array append.
There was a problem hiding this comment.
I've changed it
There was a problem hiding this comment.
Can you please rebase with main.
There was a problem hiding this comment.
Should I squash it or smth?
StupidScience
force-pushed
the
windows-support
branch
from
f3c7297
to
84de13e
Compare
StupidScience
force-pushed
the
windows-support
branch
from
84de13e
to
ab67f3c
Compare
|
@StupidScience can you give this a try on Windows and see if it works? Thanks |
StupidScience
force-pushed
the
windows-support
branch
from
ab67f3c
to
fae3775
Compare
StupidScience
force-pushed
the
windows-support
branch
from
fae3775
to
4989826
Compare
|
Squashed. Also I tried to run |
stefanprodan
approved these changes
Oct 16, 2020
ybelleguic
pushed a commit
to ybelleguic/flux2
that referenced
this pull request
Jan 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello.
Please let me know if this is something you expect here.
Or would be better to switch
execCommandto something likeexecCommand(ctx context.Context, mode ExecMode, commandName string, args ...string)?Related to #47