Fix path on flux push
#3418
Merged
Fix path on flux push
#3418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjbgf
reviewed
Dec 19, 2022
cmd/flux/push_artifact.go
Outdated
| return fmt.Errorf("invalid path '%s', must point to an existing directory or file", buildArtifactArgs.path) | ||
| path := pushArtifactArgs.path | ||
| if pushArtifactArgs.path == "-" { | ||
| path, err = saveStdinToFile() |
There was a problem hiding this comment.
saveStdinToFile is leaving the temp file opened. We need to close it before returning, otherwise os.Remove() will fail in some systems.
Please add a test for the stdin feature.
Signed-off-by: Somtochi Onyekwere <somtochionyekwere@gmail.com>
somtochiama
force-pushed
the
fix-path-push
branch
from
72f64f9
to
d79e49f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug introduced by #3389 where the path for the build cmd was used in the error message.
Also moves code for saving stdin to file before check for path
Signed-off-by: Somtochi Onyekwere somtochionyekwere@gmail.com