Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(install-script): support $GITHUB_TOKEN #3477

Merged
merged 2 commits into from
Jan 11, 2023
Merged

Conversation

raffis
Copy link
Contributor

@raffis raffis commented Jan 10, 2023

I use the install script in our ci pipeline which happen to be executed quite frequently.
We started to run into gh ratelimiting because of this script.

Run curl -s https://raw.githubusercontent.com/fluxcd/flux2/main/install/flux.sh | sudo bash
[INFO]  Downloading metadata https://api.github.com/repos/fluxcd/flux2/releases/latest
Error: Process completed with exit code 22.

This fix adds support for $GITHUB_TOKEN. If its not set it would just be an anonymous request as it was before.

Copy link
Member

@relu relu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution @raffis! 🥇

I've tested this change and it seems to work correctly both when GITHUB_TOKEN is set and not set.

Would you mind also updating the documentation so that other users will be able to more easily find this?

@raffis
Copy link
Contributor Author

raffis commented Jan 11, 2023

Would you mind also updating the documentation so that other users will be able to more easily find this?

Not at all, I updated the pr 👍🏻

Signed-off-by: Raffael Sahli <raffael.sahli@doodle.com>
install/README.md Outdated Show resolved Hide resolved
@relu relu added the area/install Install and uninstall related issues and pull requests label Jan 11, 2023
Co-authored-by: Aurel Canciu <aurelcanciu@gmail.com>
Signed-off-by: raffis <raffael.sahli@doodle.com>
@relu relu merged commit c479eb8 into fluxcd:main Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/install Install and uninstall related issues and pull requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants