flux tree: Track CRDs managed by HelmReleases #3549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiddeco
reviewed
Feb 1, 2023
| fmt.Sprintf("%s/name", helmv2.GroupVersion.Group): hr.GetName(), | ||
| fmt.Sprintf("%s/namespace", helmv2.GroupVersion.Group): hr.GetNamespace(), | ||
| } | ||
| var list apiextensionsv1.CustomResourceDefinitionList |
There was a problem hiding this comment.
Think that for tree purposes we should start looking into using PartialObjectMetadata (and PartialObjectMetadataList) from the meta API, which would make things much more lightweight.
There was a problem hiding this comment.
Apparently based on @stefanprodan his quick try-out this returns partial metadata without things like the name being set. Worth looking into at a later moment.
There was a problem hiding this comment.
We need to investigate why using metav1.PartialObjectMetadataList instead of apiextensionsv1.CustomResourceDefinitionList returns an empty list. For now I will go with this version.
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
stefanprodan
force-pushed
the
tree-hr-crds
branch
from
96c2af2
to
be154d0
Compare
hiddeco
approved these changes
Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup: fluxcd/helm-controller#596