RFC-0003: Introduce Flux OCI media type #3575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiddeco
reviewed
Feb 10, 2023
stefanprodan
force-pushed
the
rfc-0003-oci-media-type
branch
2 times, most recently
from
90a62d5
to
efc3e26
Compare
souleb
reviewed
Feb 10, 2023
21 tasks
stefanprodan
force-pushed
the
rfc-0003-oci-media-type
branch
from
efc3e26
to
df5afaf
Compare
hiddeco
approved these changes
Feb 13, 2023
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
stefanprodan
force-pushed
the
rfc-0003-oci-media-type
branch
from
df5afaf
to
c093714
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that DockerHub and all the other popular registries now support custom media type, I propose that we use
application/vnd.cncf.fluxfor the artifacts created withflux push. This change doesn't affect Flux source-controller, the controller will still work with any type of OCI artifact as long as it contains atar+gziplayer.Instead of using the Docker distribution media types, we'll be using:
application/vnd.oci.image.manifest.v1+jsonapplication/vnd.cncf.flux.config.v1+jsonapplication/vnd.cncf.flux.content.v1.tar+gzip